chore!: bump to Rust 2024 Edition by leon-xd · Pull Request #430 · microsoft/windows-drivers-rs

leon-xd · 2025-08-01T00:43:32Z

Breaking change:

MSRV bumped: 1.84 => 1.85

Other changes

unsafe wrapper around env::set_var, env::remove_var functions, and no_mangle and export_name attributes
Ran clippy on wdk crate -- this was not done in the past PRs as no automatic uncommenting of WDK configuration happens in pipeline
general fmt & clippy fixes
added cargo-sort installation to CONTRIBUTING.md

crates/cargo-wdk/tests/emulated-workspace/umdf-driver-workspace/crates/driver_1/src/lib.rs

crates/cargo-wdk/tests/common.rs

Copilot

Pull Request Overview

This PR upgrades the project to Rust 2024 Edition, requiring MSRV bump from 1.84 to 1.85. The key changes focus on wrapping unsafe operations that became required in the 2024 edition, particularly around export_name/no_mangle attributes and environment variable operations.

Updated all export_name and no_mangle attributes to use unsafe() wrapper syntax
Added safe wrapper functions for env::set_var and env::remove_var operations
Applied general formatting and clippy fixes throughout the codebase

Reviewed Changes

Copilot reviewed 47 out of 47 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
Cargo.toml	Updated edition to "2024" and rust-version to "1.85.0"
Multiple test/example files	Added `unsafe()` wrapper to `export_name` attributes with safety comments
crates/wdk-build/src/utils.rs	Added safe wrapper functions `set_var` and `remove_var` for env operations
crates/wdk-sys/src/lib.rs	Added `unsafe()` wrapper to `no_mangle` attributes with safety comments
Various source files	Applied clippy fixes including import reordering and code simplifications

crates/wdk-build/src/utils.rs

crates/cargo-wdk/tests/emulated-workspace/umdf-driver-workspace/crates/driver_1/src/lib.rs

crates/wdk-build/src/cargo_make.rs

crates/wdk-build/src/utils.rs

crates/wdk-sys/src/lib.rs

crates/wdk-build/src/utils.rs

Copilot

Pull Request Overview

Copilot reviewed 91 out of 106 changed files in this pull request and generated 27 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tests/wdk-macros-tests/src/lib.rs

examples/sample-wdm-driver/README.md

examples/sample-umdf-driver/README.md

examples/sample-kmdf-driver/README.md

crates/wdk-build/CHANGELOG.md

crates/cargo-wdk/src/actions/new/mod.rs

crates/cargo-wdk/src/actions/build/package_task.rs

README.md

Copilot

Pull Request Overview

Copilot reviewed 52 out of 52 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/wdk-build/src/utils.rs

Copilot

Pull Request Overview

Copilot reviewed 69 out of 80 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/wdk/src/wdf/timer.rs

crates/wdk-build/src/utils.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Leon Durrenberger <leon.durrenberger@gmail.com>

Copilot

Pull Request Overview

Copilot reviewed 69 out of 80 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/wdk-build/rust-driver-makefile.toml

Copilot

Pull Request Overview

Copilot reviewed 53 out of 64 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/wdk-build/src/cargo_make.rs

crates/cargo-wdk/tests/test_utils/mod.rs

crates/cargo-wdk/src/test_utils.rs

crates/wdk-build/src/utils.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Leon Durrenberger <leon.durrenberger@gmail.com>

Copilot

Pull Request Overview

Copilot reviewed 53 out of 64 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Leon Durrenberger <leon.durrenberger@gmail.com>

Copilot

Pull Request Overview

Copilot reviewed 53 out of 64 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

gurry

LGTM.

@leon-xd quick question: why didn't our pipelines catch the wrong macrotest output files? Are we missing some coverage in this area?

leon-xd added 3 commits July 31, 2025 17:32

Migration to Rust 2024

0b755a5

Recommented driver configuration

ed382b4

removed check on save blocker in vscode config

e5cf361

Copilot AI review requested due to automatic review settings August 1, 2025 00:43

This comment was marked as outdated.

Sign in to view

wmmc88 reviewed Aug 1, 2025

View reviewed changes

crates/cargo-wdk/tests/emulated-workspace/umdf-driver-workspace/crates/driver_1/src/lib.rs Show resolved Hide resolved

wmmc88 reviewed Aug 1, 2025

View reviewed changes

crates/cargo-wdk/tests/common.rs Outdated Show resolved Hide resolved

leon-xd added 10 commits August 4, 2025 11:55

Addressed comments

4f3bb02

ran formatter

a2ae1c0

fixed doc test issues

a5be482

Migration to Rust 2024

1db477b

Recommented driver configuration

7d15f1d

removed check on save blocker in vscode config

0f6414d

Addressed comments

8475b4a

ran formatter

0b420a4

fixed import in cargo_make.rs

a4e0f09

resolve merge conflicts

3dce48e

wmmc88 requested a review from Copilot August 5, 2025 22:03

Copilot AI reviewed Aug 5, 2025

View reviewed changes

crates/wdk-build/src/utils.rs Outdated Show resolved Hide resolved

crates/wdk-build/src/utils.rs Outdated Show resolved Hide resolved

wmmc88 requested changes Aug 5, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings September 29, 2025 23:54

Copilot AI reviewed Sep 29, 2025

View reviewed changes

correct merge

f27ceab

wmmc88 added the next-release-priority Issues and PRs that should be prioritized to be in the next crates.io release label Sep 30, 2025

wmmc88 mentioned this pull request Oct 2, 2025

feat: support stampinf version override #520

Merged

target detection instead of host detection

3b43728

leon-xd force-pushed the update-rust-2024 branch from 40f6ba7 to 3b43728 Compare October 7, 2025 19:09

added rest of safety comments

18858d1

Copilot AI review requested due to automatic review settings October 8, 2025 19:03

Copilot AI reviewed Oct 8, 2025

View reviewed changes

crates/wdk-build/src/utils.rs Outdated Show resolved Hide resolved

crates/wdk-build/src/utils.rs Outdated Show resolved Hide resolved

added cfg guard for safe_env_vars tests

0d811d5

Copilot AI review requested due to automatic review settings October 14, 2025 22:38

Copilot AI reviewed Oct 14, 2025

View reviewed changes

crates/wdk/src/wdf/timer.rs Outdated Show resolved Hide resolved

crates/wdk-build/src/utils.rs Show resolved Hide resolved

Update crates/wdk/src/wdf/timer.rs

8ca4e00

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Leon Durrenberger <leon.durrenberger@gmail.com>

Copilot AI review requested due to automatic review settings October 14, 2025 22:41

Copilot AI reviewed Oct 14, 2025

View reviewed changes

crates/wdk-build/rust-driver-makefile.toml Show resolved Hide resolved

Removed accidental copied files

5c4ae9e

gurry previously approved these changes Oct 15, 2025

View reviewed changes

Restore symbolic links in wdk-macros-tests from commit 17b05c3

c54587c

Copilot AI review requested due to automatic review settings October 15, 2025 23:02

leon-xd dismissed gurry’s stale review via c54587c October 15, 2025 23:02

Copilot AI reviewed Oct 15, 2025

View reviewed changes

crates/wdk-build/src/cargo_make.rs Outdated Show resolved Hide resolved

crates/cargo-wdk/tests/test_utils/mod.rs Outdated Show resolved Hide resolved

crates/cargo-wdk/src/test_utils.rs Outdated Show resolved Hide resolved

crates/wdk-build/src/utils.rs Outdated Show resolved Hide resolved

Update crates/cargo-wdk/tests/test_utils/mod.rs

cdb0c0c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Leon Durrenberger <leon.durrenberger@gmail.com>

Copilot AI review requested due to automatic review settings October 15, 2025 23:04

Update crates/wdk-build/src/utils.rs

86b9399

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Leon Durrenberger <leon.durrenberger@gmail.com>

Copilot AI reviewed Oct 15, 2025

View reviewed changes

Update crates/cargo-wdk/src/test_utils.rs

a37a004

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Leon Durrenberger <leon.durrenberger@gmail.com>

Copilot AI review requested due to automatic review settings October 15, 2025 23:05

Copilot AI reviewed Oct 15, 2025

View reviewed changes

reverted all to_string functions to shorter path

9865b24

leon-xd requested review from gurry and krishnakumar4a4 October 15, 2025 23:48

krishnakumar4a4 approved these changes Oct 16, 2025

View reviewed changes

gurry approved these changes Oct 16, 2025

View reviewed changes

leon-xd added this pull request to the merge queue Oct 16, 2025

Merged via the queue into microsoft:main with commit de6622a Oct 16, 2025
229 checks passed

leon-xd deleted the update-rust-2024 branch October 16, 2025 07:09

leon-xd mentioned this pull request Oct 17, 2025

chore: release #552

Closed

wmmc88 mentioned this pull request Nov 6, 2025

chore: November 2025 release #562

Merged

Conversation

leon-xd commented Aug 1, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

gurry left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

gurry left a comment •

edited

Loading